Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapidjson: disable tests which fail to compile #355633

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

paparodeo
Copy link
Contributor

disable two tests which fail to compile on clang-19 due to trying to use an unsigned type for which a std::char_traits does not exist.

Tencent/rapidjson#2318

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy

disable two tests which fail to compile on clang-19 due to trying to use
an unsigned type for which a std::char_traits does not exits.
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subscribed to the issue, so hopefully I’ll remember to remove this when it’s no longer necessary.

@emilazy emilazy merged commit 54f4942 into NixOS:llvm-19 Nov 13, 2024
10 of 11 checks passed
@paparodeo paparodeo deleted the rapidjson-disable-tests branch November 13, 2024 12:50
emilazy added a commit to emilazy/nixpkgs that referenced this pull request Nov 16, 2024
emilazy added a commit to emilazy/nixpkgs that referenced this pull request Nov 17, 2024
emilazy added a commit to emilazy/nixpkgs that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants