yosys: 0.47 -> 0.48 #368946
Merged
yosys: 0.47 -> 0.48 #368946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-ryantm couldn't perform this update automatically because the tag names seem to have changed from `0.x` to `v0.x`. Yosys's test suite also now seems to rely on gtkwave for `vcd2fst`.
Luflosi
approved these changes
Dec 29, 2024
thoughtpolice
approved these changes
Dec 30, 2024
Liamolucko
added a commit
to Liamolucko/nixpkgs
that referenced
this pull request
Dec 31, 2024
Its tag naming was changed the same as Yosys, so r-ryantm couldn't update it either. This also gets sby working with Yosys 0.48; I didn't notice it being broken in NixOS#368946 because I only ran `nixpkgs-review` on macOS where sby doesn't build due to broken dependencies anyway. Sorry!
thomasjm
pushed a commit
to codedownio/nixpkgs
that referenced
this pull request
Jan 5, 2025
Its tag naming was changed the same as Yosys, so r-ryantm couldn't update it either. This also gets sby working with Yosys 0.48; I didn't notice it being broken in NixOS#368946 because I only ran `nixpkgs-review` on macOS where sby doesn't build due to broken dependencies anyway. Sorry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r-ryantm couldn't perform this update automatically because the tag names seem to have changed from
0.xtov0.x.Yosys's test suite also now seems to rely on gtkwave for
vcd2fst.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.