Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poppler: pull in missing libtiff dependency #370052

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jan 1, 2025

Without the change the staging build fails as:

poppler-glib> CMake Error at CMakeLists.txt:162 (MESSAGE):
poppler-glib>   Could not find the 4.1 version of TIFF.  If you're not interested in the
poppler-glib>   features it provides set the cmake ENABLE_LIBTIFF option to OFF

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Without the change the `staging` build fails as:

    poppler-glib> CMake Error at CMakeLists.txt:162 (MESSAGE):
    poppler-glib>   Could not find the 4.1 version of TIFF.  If you're not interested in the
    poppler-glib>   features it provides set the cmake ENABLE_LIBTIFF option to OFF
@uninsane
Copy link
Contributor

uninsane commented Jan 2, 2025

we were propagating this previously, via the dep on lcms2, so i'll merge this as-is in the interest of fixing the build in a way we know works for poppler's dependents (once my local build finishes). but there is a TODO in the poppler nix file about reducing propagated deps: has anyone looked into the details there?

@uninsane uninsane merged commit 1460b5f into NixOS:staging Jan 2, 2025
39 of 40 checks passed
@trofi trofi deleted the poppler-add-libtiff branch January 2, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants