piston-cli: 1.4.3 -> 1.5.0

[ethancedwards8]

Things done

Updated piston-cli to latest version

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[lucasew]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370707

---

x86_64-linux

❌ 2 packages failed to build:

• piston-cli
• piston-cli.dist

[lucasew]

Logs:

Sourcing python-remove-tests-dir-hook
Sourcing python-catch-conflicts-hook.sh
Sourcing python-remove-bin-bytecode-hook.sh
Sourcing pypa-build-hook
Using pypaBuildPhase
Sourcing python-runtime-deps-check-hook
Using pythonRuntimeDepsCheckHook
Sourcing pypa-install-hook
Using pypaInstallPhase
Sourcing python-imports-check-hook.sh
Using pythonImportsCheckPhase
Sourcing python-namespaces-hook
Sourcing python-catch-conflicts-hook.sh
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/06k9xfzc2vywkcjnqkfgpl8s5lyyqr2d-piston-cli-1.5.0.tar.gz
source root is piston-cli-1.5.0
setting SOURCE_DATE_EPOCH to timestamp 1633081617 of file piston-cli-1.5.0/PKG-INFO
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
no configure script, doing nothing
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Executing pypaBuildPhase
Creating a wheel...
pypa build flags: --no-isolation --outdir dist/ --wheel
�[1m* Getting build dependencies for wheel...�[0m
�[1m* Building wheel...�[0m
�[1m�[92mSuccessfully built �[4mpiston_cli-1.5.0-py3-none-any.whl�[0m�[1m�[92m�[0m
Finished creating a wheel...
/build/piston-cli-1.5.0/dist /build/piston-cli-1.5.0
Unpacking to: unpacked/piston_cli-1.5.0...OK
Repacking wheel as ./piston_cli-1.5.0-py3-none-any.whl...OK
/build/piston-cli-1.5.0
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for piston_cli-1.5.0-py3-none-any.whl
  - appdirs not installed
  - click not installed
  - coloredlogs not installed
  - requests-cache not installed

[ethancedwards8]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370707

x86_64-linux

❌ 2 packages failed to build:

Unrelated, but I tried to run nixpkgs-review and for over an hour it did not finish. I have 16GB or ram and a Ryzen 2600X. My machine is not old or slow. Since when does nixpkgs-review take so much memory and so much time to use? It wasn't like this ~3 years ago when I first got into Nix.

[lucasew]

nixpkgs-review result

Generated using nixpkgs-review.
Command: nixpkgs-review pr 370707

x86_64-linux

❌ 2 packages failed to build:

Unrelated, but I tried to run nixpkgs-review and for over an hour it did not finish. I have 16GB or ram and a Ryzen 2600X. My machine is not old or slow. Since when does nixpkgs-review take so much memory and so much time to use? It wasn't like this ~3 years ago when I first got into Nix.

Local eval is very RAM hungry. I did a PoC to emit the data using builtins.trace to avoid having to collect all the stuff in one structure tho.

I run the reviews in a 32GB Ryzen 5 5600G tho

[ethancedwards8]

nixpkgs-review result

Generated using nixpkgs-review.
Command: nixpkgs-review pr 370707

x86_64-linux

❌ 2 packages failed to build:

Unrelated, but I tried to run nixpkgs-review and for over an hour it did not finish. I have 16GB or ram and a Ryzen 2600X. My machine is not old or slow. Since when does nixpkgs-review take so much memory and so much time to use? It wasn't like this ~3 years ago when I first got into Nix.

Local eval is very RAM hungry. I did a PoC to emit the data using builtins.trace to avoid having to collect all the stuff in one structure tho.

I run the reviews in a 32GB Ryzen 5 5600G tho

nix build .#piston-cli is not as hungry though. Also, what is a PoC?

[lucasew]

Proof of concept. I wanted to do evals as a build on a remote builder.

#357934

[FliegendeWurst]

Even with requests-cache added to pythonRelaxDeps, I get an error

Traceback (most recent call last):
  File "/nix/store/i70vphsz9j01qnnq2xk96n65cbgj3l4x-piston-cli-1.5.0/bin/.piston-wrapped", line 6, in <module>
    from piston import main
ImportError: cannot import name 'main' from 'piston' (/nix/store/i70vphsz9j01qnnq2xk96n65cbgj3l4x-piston-cli-1.5.0/lib/python3.12/site-packages/piston/__init__.py)

[lucasew]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370707

---

x86_64-linux

❌ 2 packages failed to build:

• piston-cli
• piston-cli.dist

[ethancedwards8]

I think the conclusion here is that I suck at packaging Python apps.

[lucasew]

I think the conclusion here is that I suck at packaging Python apps.

Everyone here sucked at it in some point.

Nix is much more strict and rigorous in the details. All other methods are much more flexible and this makes stuff a little harder. It happens. I am using Nix and contributing to nixpkgs for about 4 years and I still often discover new cool things!