Drydeposition #88
Drydeposition #88
Conversation
|
@rosiealice - thanks for this. Can you summarize what test(s) you ran with this - and what code base? That would be super helpful. Actually - looking at the PR changes - I'm not sure this is needed for this PR - but its good practice to include this. |
src/utils/clmfates_interfaceMod.F90
Outdated
| @@ -1608,7 +1610,8 @@ subroutine wrap_update_hlmfates_dyn(this, nc, bounds_clump, & | |||
| z0m(col%patchi(c)+1:col%patchf(c)) = 0.0_r8 | |||
| displa(col%patchi(c)+1:col%patchf(c)) = 0.0_r8 | |||
| dleaf_patch(col%patchi(c)+1:col%patchf(c)) = 0.0_r8 | |||
|
|
|||
| wesley_pft_index_patch(col%patchi(c)+1:col%patchf(c)) = 0 | |||
There was a problem hiding this comment.
Can you do 0.0_r8 here, like it is done everywhere?
There was a problem hiding this comment.
In DryDepVelocity the initital valaue is -1 and there are checks <0.
There was a problem hiding this comment.
These are defined at integers in Canopystatemod so I think they should just be '0'?
Would it be good form to start this as the unset values of -1? Or just stick to 'zaeroing'?
|
One of my issues is that with |
|
Also, Can you add checks for valid index values either in DryDepVelocity or in clmfates_interfaceMod where values from fates are passed? There should be an endrun with |
|
Hi @mvertens. Maybe hold off on merging it yet. I am still testing the FATES side changes, so this is not yet finished... |
|
@rosiealice - would be good to have this in draft form if you are still testing. And I've been talking to @mvdebolskiy and we feel that we should have a pared down test suite for betzy on our end that is always run as part of PRs. Let's talk more at tomorrow's meeting. |
|
Sure. I pressed the 'convert to draft' button. Was that right? :) |
|
Perfect! |
|
@mvdebolskiy I changed the logic here if ( n_drydep > 0 .and. .not. use_fates ) then |
|
I made paired CLM-SP and FATES-SP simulations to compare the dry deposition outputs. The CLM-SP simulation is here: and the FATES-SP case is here: I ran these for three years each with -drydep specified by This is a random month of output run through my crude plotting script (working on getting these into a diagnostics package is on our to do list). The differences are very small (suspiciously so??!) but nonetheless, here they are. As for the MEGAN PR, I think this code is ready for running through tests. @mvdebolskiy @mvertens Plotted by gridcell
Plotted by latitude
Only the differences plotted (to check they are not all zeros)
|
Description of changes
Does not update the science parts of the season_index calculation, yet..
To pair with forthcoming FATES-side changes.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)?
Any User Interface Changes (namelist or namelist defaults changes)?
Does this create a need to change or add documentation? Did you do so?
Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)
NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).