Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminating ncbitaxon:root and instead bridging to true organism subclasses #211

Merged
merged 1 commit into from
Nov 2, 2022

Commits on Aug 19, 2022

  1. Eliminating ncbitaxon:root and instead bridging to true organism subc…

    …lasses
    
    **please read closely and read the related issue before commenting**
    
    This PR removed the statement that COB:organism = NCBITaxon:root
    
    Rationale: root includes non-organisms such as samples
    
    See obophenotype/ncbitaxon#10
    
    This PR replaces that link with two subClassOf axioms
    
     * COB:organism
        * NCBITaxon:Viruses
        * NCBITaxon:cellular organisms
    
    Note that if this were merged, then the union of NCBITaxon and COB would have a lattice at the top. However, it would be trivial to add NCBITaxon:1 to an anti-slim and filter it out, resulting in a tree with COB:organism as the single MRCA of all organism classes
    
    Merging this PR has some advantages such as obviating the need to rename NCBITaxon:1, since we instead simply inject our own true parent. It leaves the structure of labeling of NCBITaxon intact
    
    **Important** please refrain from discussing the definition of organism here, specifically whether it includes viruses. For COB purposes, this is a closed issue. See: #6
    cmungall authored Aug 19, 2022
    Configuration menu
    Copy the full SHA
    1948d45 View commit details
    Browse the repository at this point in the history