Eliminating ncbitaxon:root and instead bridging to true organism subclasses #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lasses **please read closely and read the related issue before commenting** This PR removed the statement that COB:organism = NCBITaxon:root Rationale: root includes non-organisms such as samples See obophenotype/ncbitaxon#10 This PR replaces that link with two subClassOf axioms * COB:organism * NCBITaxon:Viruses * NCBITaxon:cellular organisms Note that if this were merged, then the union of NCBITaxon and COB would have a lattice at the top. However, it would be trivial to add NCBITaxon:1 to an anti-slim and filter it out, resulting in a tree with COB:organism as the single MRCA of all organism classes Merging this PR has some advantages such as obviating the need to rename NCBITaxon:1, since we instead simply inject our own true parent. It leaves the structure of labeling of NCBITaxon intact **Important** please refrain from discussing the definition of organism here, specifically whether it includes viruses. For COB purposes, this is a closed issue. See: #6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please read closely and read the related issue before commenting
This PR removed the statement that COB:organism = NCBITaxon:root
Rationale: root includes non-organisms such as samples
See obophenotype/ncbitaxon#10
This PR replaces that link with two subClassOf axioms
Note that if this were merged, then the union of NCBITaxon and COB would have a lattice at the top. However, it would be trivial to add NCBITaxon:1 to an anti-slim and filter it out, resulting in a tree with COB:organism as the single MRCA of all organism classes
Merging this PR has some advantages such as obviating the need to rename NCBITaxon:1, since we instead simply inject our own true parent. It leaves the structure of labeling of NCBITaxon intact
Important please refrain from discussing the definition of organism here, specifically whether it includes viruses. For COB purposes, this is a closed issue. See: #6