[16.0][IMP] account_invoice_fixed_discount: avoid replace in xml #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PieterPaulussen could you review? |
CRogos
force-pushed
the
16.0-imp-account_invoice_fixed_discount
branch
from
03d9ea4 to
f837b86
Compare
|
@JordiBForgeFlow could you review and merge this? |
|
This PR has the |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at d481144. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently facing a problem with to many decimal numbers in a standard Odoo installation on the invoice PDF.
I assume this causes by this code section:
I also evaluated that adding this options will solve the issue in standard Odoo:
t-options='{"widget": "float", "decimal_precision": "Discount"}'
https://github.com/odoo/odoo/blob/5911f056f9ed45a82a694782f82aa3170d0b74ac/addons/account/views/report_invoice.xml#L126C49-L126C100
But this module is using replace, which would bring back the problem. Therefore I would like to change the xml not using "replace".