[17.0][MIG] account_invoice_refund_link: Migration to 17.0 #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhancements: * Reverse link from invoice to refunds also available. * Link at invoice line level, not only at invoice level. * When installing the module after some refunds have been made, the module tries to find the link to the original invoice for them. * OCA Guidelines compliance. * Compatibility in OpenUpgrade for migrating from 8.0 module account_refund_original. * Tests with 100% coverage. Technical changes: * Rename field origin_invoices_ids to origin_invoice_ids * Rename field refund_invoices_description to refund_reason * Rename addon to account_invoice_refund_link
Odoo already includes a method for preparing the refund, so using it we don't have to make any guess about the returned domain and the method also serves for refunds created directly by code. Initial line match has also been improved comparing product or description.
* [FIX] account_invoice_refund_link: Don't copy m2m fields Many2many fields have copy=True property by default, having an incorrect duplication of origin or refund invoices. Steps to reproduce: * Create an invoice * Refund it * Duplicate the original invoice * The refund will be link to 2 original invoices Included tests covering the use cases for avoiding future regressions.
Since v11, Odoo counts with a field called `refund_invoice_ids` of type one2many, which conflicts with the m2m field defined in this module. Moreover, these fields are not needed anymore. There is only 2 OCA modules using this module right now, and they don't need significant changes for this adaptation, but I will do it when this get merged.
Currently translated at 100.0% (17 of 17 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_refund_link/de/
Currently translated at 100.0% (17 of 17 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_refund_link/pt_BR/
Currently translated at 100.0% (11 of 11 strings) Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_refund_link/pt_BR/
…edit note invoice has done from sale order.
Currently translated at 100.0% (12 of 12 strings) Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_refund_link/pt_BR/
|
/ocabot migration account_invoice_refund_link |
andrel-exo
changed the title
CRogos
suggested changes
Mar 25, 2024
There was a problem hiding this comment.
Please have a look in to the migration guid:
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0
- The commit history is not cleaned up.
- The required commits missing and your changes are mixed up into one commit
- [IMP] $module: pre-commit auto fixes
- [MIG] $module: Migration to 17.0
There was a problem hiding this comment.
The readme files need to be kept as md files!
andrel-exo
force-pushed
the
17.0_account_invoice_refund_link
branch
from
5fdd8c5
to
9642655
Compare
CRogos
reviewed
Mar 26, 2024
There was a problem hiding this comment.
Better but not yet 100%.
According to the migration guide, the last commits should look like this:
Here you can find the instruction how and which commits to squash: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate
Here are some samples>
Currently translated at 91.6% (11 of 12 strings) Translation: account-invoicing-15.0/account-invoicing-15.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_invoice_refund_link/ca/
With the previous algorithm, if something modifies the order of the returned lines, there are chances of linking invoice lines with non refund lines (but other journal items). We assure at least that only refund lines are linked restricting the iteration on them. TT38633
Currently translated at 100.0% (12 of 12 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_refund_link/hr/
Currently translated at 100.0% (12 of 12 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_refund_link/pt/
On the side by side comparison, exclude the lines that are not products, as that's what we do on the refund lines.
Hooking on a high level method like `_reverse_moves` (although still being private), makes that other modules hooking into it may alter the number of returned lines (like for example, account_invoice_refund_line_selection). We choose the low-level `copy_data` method that is used in such method for linking the refund lines with their origin ones, avoiding the problem.
Currently translated at 100.0% (12 of 12 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_refund_link/es/
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (12 of 12 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_refund_link/pt_BR/
Currently translated at 100.0% (12 of 12 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_refund_link/it/
andrel-exo
force-pushed
the
17.0_account_invoice_refund_link
branch
from
f2c12d9
to
676f4d8
Compare
CRogos
approved these changes
Apr 24, 2024
|
@pedrobaeza can you merge? |
|
This PR has the |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 216644c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.