Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][ADD] edi_exchange_template_oca_json #137

Open
wants to merge 3 commits into
base: 18.0
Choose a base branch
from

Conversation

wouitmil
Copy link

No description provided.

@wouitmil wouitmil changed the title 18.0 add edi exchange template json [18.0][ADD] 18.0 add edi exchange template json Feb 3, 2025
@wouitmil wouitmil changed the title [18.0][ADD] 18.0 add edi exchange template json [18.0][ADD] add edi exchange template json Feb 3, 2025
@wouitmil wouitmil changed the title [18.0][ADD] add edi exchange template json [18.0][ADD] edi_exchange_template_oca_json Feb 3, 2025
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls drop the odoo version from commits and squash them.
You might want to add yourself to contribs ;)


def _post_process_json_output(self, output):
"""Post-process JSON output."""
return str(output)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return str(output)
return json.dumps(output)


def test_01_generate_json(self):
self.backend.exchange_generate(self.record_json)
expected = f"{{'name': '{self.partner.name}', 'ref': '{self.partner.ref}'}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expected = f"{{'name': '{self.partner.name}', 'ref': '{self.partner.ref}'}}"
expected = json.dumps({"name": self.partner.name, "ref": self.partner.ref})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants