Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] [15.0] purchase_warn_option #2240

Merged
merged 1 commit into from
Jun 6, 2024
Merged

[ADD] [15.0] purchase_warn_option #2240

merged 1 commit into from
Jun 6, 2024

Conversation

Shide
Copy link
Contributor

@Shide Shide commented Apr 16, 2024 •
edited
Loading

This module extends the functionality of blocking messages to support more consistency
between messages and to allow you to set a blocking message quickly.

This is a PR of a series:

base_warn_option
sale_warn_option
account_warn_option
stock_warn_option

MT-5193 @moduon @rafaelbn @yajo @EmilioPascual please review if you want :)

This was referenced Apr 16, 2024
Merged
Merged
@Shide Shide marked this pull request as draft April 16, 2024 10:37
yajo
yajo requested changes Apr 16, 2024
View reviewed changes
purchase_warn_option/__manifest__.py Outdated Show resolved Hide resolved
purchase_warn_option/readme/CONTEXT.md Outdated Show resolved Hide resolved
@Shide Shide force-pushed the 15.0-purchase_warn_option-purchase_warn_option branch from 1033911 to 1501f06 Compare April 16, 2024 10:52
@Shide Shide mentioned this pull request Apr 16, 2024
Merged
@Shide Shide marked this pull request as ready for review April 16, 2024 11:01
@Shide Shide mentioned this pull request Apr 16, 2024
Merged
@Shide Shide requested a review from yajo April 16, 2024 11:08
@Shide Shide force-pushed the 15.0-purchase_warn_option-purchase_warn_option branch from 1501f06 to db58154 Compare April 16, 2024 11:17
@rafaelbn rafaelbn added this to the 15.0 milestone Apr 16, 2024
@rafaelbn
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@rafaelbn The rebase process failed, because command git push --force moduon tmp-pr-2240:15.0-purchase_warn_option-purchase_warn_option failed with output:

remote: Permission to moduon/purchase-workflow.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/moduon/purchase-workflow/': The requested URL returned error: 403

@Shide Shide force-pushed the 15.0-purchase_warn_option-purchase_warn_option branch from db58154 to cd98195 Compare April 17, 2024 07:42
yajo
yajo approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the tests.

EmilioPascual
EmilioPascual approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and Code review

rafaelbn
rafaelbn approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-2240-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 6, 2024
@OCA-git-bot
Merge PR #2240 into 15.0
1b808cb 
Signed-off-by rafaelbn
@OCA-git-bot
Copy link
Contributor

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-2240-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@yajo
Copy link
Member

yajo commented May 7, 2024

@Shide please check test failures.

@Shide
Copy link
Contributor Author

Shide commented Jun 4, 2024

Could you please check tests?

@marcelsavegnago: purchase_default_terms_conditions
@sebastienbeau: purchase_quick
@gurneyalex: purchase_order_analytic_search

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-2240-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit de7b09d into OCA:15.0 Jun 6, 2024
3 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7279c1b. Thanks a lot for contributing to OCA. ❤️

@Shide Shide deleted the 15.0-purchase_warn_option-purchase_warn_option branch June 10, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilioPascual EmilioPascual EmilioPascual approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

@yajo yajo yajo approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs fixing needs review
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Shide @rafaelbn @OCA-git-bot @yajo @gurneyalex @EmilioPascual @dreispt