Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] [15.0] stock_warn_option #1571

Merged

Conversation

Shide
Copy link
Contributor

@Shide Shide commented Apr 16, 2024

This module extends the functionality of blocking messages to support more consistency
between messages and to allow you to set a blocking message quickly.

This is a PR of a series:

base_warn_option
sale_warn_option
purchase_warn_option
account_warn_option

MT-5193 @moduon @rafaelbn @yajo @EmilioPascual please review if you want :)

@rafaelbn
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@rafaelbn The rebase process failed, because command git push --force moduon tmp-pr-1571:15.0-stock_warn_option-stock_warn_option failed with output:

remote: Permission to moduon/stock-logistics-workflow.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/moduon/stock-logistics-workflow/': The requested URL returned error: 403

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Minor comment

stock_warn_option/tests/test_warn_options.py Outdated Show resolved Hide resolved
@Shide Shide force-pushed the 15.0-stock_warn_option-stock_warn_option branch from dd74b30 to dd296ab Compare April 17, 2024 07:44
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Apr 24, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1571-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0358b29 into OCA:15.0 Apr 24, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2192cc1. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 15.0-stock_warn_option-stock_warn_option branch April 25, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants