-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] fastapi: Tests broken #470
Comments
Thank you @paradoxxxzero for the report. I'll dig into this problem once I'll have some time. |
cc @grindtildeath as the author of the above mentioned commit in case this rings a bell |
@sbidoul I haven't analyzed how the above mentioned commit affects other auth flows or v16.0 as my original commit was on v14.0. I tried my best to describe what was happening with OAuth activated (ie outdated cursor when validating the session due to isolation level) in the commit message, but cannot tell much more. I guess @simahawk forward ported the commit to avoid having to spend as much time as we did to find it out, but without reproducing and an in depth analysis I cannot be of much help 😥 |
As far I as remember, the tests fail because it expects no commits on an error request and the aforementioned commit introduces a new dedicated cursor (to avoid using the request's one) which does indeed a commit when exiting the context manager |
Pushed a fix upstream OCA/web-api#77 |
FYI fastapi tests are now broken due to this merge : OCA/web-api@66cf0ba
See in this PR #468 for instance (https://github.com/OCA/rest-framework/actions/runs/11707312885/job/32606402396?pr=468)
The text was updated successfully, but these errors were encountered: