Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] endpoint_route_handler: Rollback dedicated routing cursor #77

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[FIX] endpoint_route_handler: Rollback dedicated routing cursor #77

wants to merge 1 commit into from
+9 −1

Conversation

paradoxxxzero
Copy link

Unless I am missing something, we should not commit this transaction (registry.cursor() commits at __exit__ ).

This fix the failing tests in rest-framework: OCA/rest-framework#470

@OCA-git-bot
Copy link
Contributor

Hi @simahawk,
some modules you are maintaining are being modified, check this out!

@paradoxxxzero paradoxxxzero mentioned this pull request Dec 9, 2024
Open
simahawk
simahawk approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, good catch :)

@paradoxxxzero paradoxxxzero force-pushed the 16.0-fix-endpoint_route_handler branch from 19023b5 to 0190a5c Compare December 13, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paradoxxxzero @OCA-git-bot @simahawk