-
-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG] partner_location_auto_create: Migration to 13.0 #2056
base: 13.0
Are you sure you want to change the base?
[13.0][MIG] partner_location_auto_create: Migration to 13.0 #2056
Conversation
69f07c5
to
7bdfa05
Compare
/ocabot migration partner_location_auto_create |
@Ana-Iarajuli I think you should retry the migration process as you should keep commit history and pre-commit should pass too. |
7bdfa05
to
b83f952
Compare
my checks failed due to the absence of freezegun in 13.0. Created back-port in OCA/OCB: https://github.com/OCA/OCB/pull/1236 |
34a22cc
to
f522590
Compare
test_requirements.txt
Outdated
@@ -1 +1,2 @@ | |||
freezegun | |||
freezegun==0.3.11; python_version < '3.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file name should be test-requirements.txt
(with dash, not underscore).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the name, but pre-commit check is failing along with other 2 checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ana-Iarajuli IMHO, you should install pre-commit locally to see the detailed error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rousseldenis I ran pre-commit couple of times and all the checks are passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is your branch rebased on OCA/13.0 ?
f522590
to
e21b5ee
Compare
@Ana-Iarajuli Could you fix tests also ? |
Migrated partner_location_auto_create from 10.0 to 13.0 using following conventions: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0#how-to