Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] partner_location_auto_create: Migration to 13.0 #2056

Open
wants to merge 3 commits into
base: 13.0
Choose a base branch
from

Conversation

Ana-Iarajuli
Copy link

Migrated partner_location_auto_create from 10.0 to 13.0 using following conventions: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0#how-to

@Ana-Iarajuli Ana-Iarajuli force-pushed the 13.0-mig-partner_location_auto_create branch 2 times, most recently from 69f07c5 to 7bdfa05 Compare June 14, 2024 09:33
@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration partner_location_auto_create

@rousseldenis
Copy link
Sponsor Contributor

@Ana-Iarajuli I think you should retry the migration process as you should keep commit history and pre-commit should pass too.

@Ana-Iarajuli
Copy link
Author

my checks failed due to the absence of freezegun in 13.0. Created back-port in OCA/OCB: https://github.com/OCA/OCB/pull/1236

@Ana-Iarajuli Ana-Iarajuli force-pushed the 13.0-mig-partner_location_auto_create branch from 34a22cc to f522590 Compare June 19, 2024 09:50
@@ -1 +1,2 @@
freezegun
freezegun==0.3.11; python_version < '3.8'
Copy link
Member

@pedrobaeza pedrobaeza Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file name should be test-requirements.txt (with dash, not underscore).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the name, but pre-commit check is failing along with other 2 checks

Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ana-Iarajuli IMHO, you should install pre-commit locally to see the detailed error

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis I ran pre-commit couple of times and all the checks are passed

Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is your branch rebased on OCA/13.0 ?

@Ana-Iarajuli Ana-Iarajuli force-pushed the 13.0-mig-partner_location_auto_create branch from f522590 to e21b5ee Compare June 19, 2024 10:11
@rousseldenis
Copy link
Sponsor Contributor

@Ana-Iarajuli Could you fix tests also ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants