-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] membership_extension: Migration to 18.0 #198
Open
BhaveshHeliconia
wants to merge
90
commits into
OCA:18.0
Choose a base branch
from
HeliconiaIO:18.0-mig-membership_extension
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] membership_extension: Migration to 18.0 #198
BhaveshHeliconia
wants to merge
90
commits into
OCA:18.0
from
HeliconiaIO:18.0-mig-membership_extension
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
* Avoid ensure_one errors. * Don't do anything when there's no origin (refund made from scratch or field erased). * Use more accurate origin field (if refund link module installed) Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
- Partners can't be deleted if they have member lines. Signed-off-by: Carmen Bianca Bakker <[email protected]>
…red member (OCA#51) - A member who is associated to another have the option to set start date independently from the associate member one Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
This module uses in previous versions an indirect dependency to account_invoice_refund_link for detecting the origin invoice where the refund comes from, but now there's a field in standard for pointing to that origin invoice, so no need of such code. Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] Update membership_extension.pot Signed-off-by: Carmen Bianca Bakker <[email protected]>
Currently translated at 37.8% (14 of 37 strings) Translation: vertical-association-11.0/vertical-association-11.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-11-0/vertical-association-11-0-membership_extension/de/ Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] Update membership_extension.pot Signed-off-by: Carmen Bianca Bakker <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: vertical-association-12.0/vertical-association-12.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-12-0/vertical-association-12-0-membership_extension/ Signed-off-by: Carmen Bianca Bakker <[email protected]>
- Demo membership products weren't membership products Signed-off-by: Carmen Bianca Bakker <[email protected]>
Currently translated at 62.5% (40 of 64 strings) Translation: vertical-association-12.0/vertical-association-12.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-12-0/vertical-association-12-0-membership_extension/de/ Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] README.rst Signed-off-by: Carmen Bianca Bakker <[email protected]>
Currently translated at 81.2% (52 of 64 strings) Translation: vertical-association-12.0/vertical-association-12.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-12-0/vertical-association-12-0-membership_extension/de/ Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] Update membership_extension.pot Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] README.rst Signed-off-by: Carmen Bianca Bakker <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: vertical-association-13.0/vertical-association-13.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-13-0/vertical-association-13-0-membership_extension/ Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] Update membership_extension.pot Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] README.rst Signed-off-by: Carmen Bianca Bakker <[email protected]>
Currently translated at 77.2% (51 of 66 strings) Translation: vertical-association-14.0/vertical-association-14.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-14-0/vertical-association-14-0-membership_extension/it/ Signed-off-by: Carmen Bianca Bakker <[email protected]>
Currently translated at 89.3% (59 of 66 strings) Translation: vertical-association-14.0/vertical-association-14.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-14-0/vertical-association-14-0-membership_extension/it/ Signed-off-by: Carmen Bianca Bakker <[email protected]>
Currently translated at 100.0% (66 of 66 strings) Translation: vertical-association-14.0/vertical-association-14.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-14-0/vertical-association-14-0-membership_extension/it/ Signed-off-by: Carmen Bianca Bakker <[email protected]>
Currently translated at 100.0% (66 of 66 strings) Translation: vertical-association-14.0/vertical-association-14.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-14-0/vertical-association-14-0-membership_extension/it/ Signed-off-by: Carmen Bianca Bakker <[email protected]>
…elds are always truthy This is an additional sanity check to make sure that fields that are expected to be available are actually available. The situation here is a little tricky. Especially as pertains date_from and date_to; these fields are `required=True` nowhere. Not on the product, not on the membership invoice, and not on the membership line. However, they _are_ set as required in the product and membership line views. If these values are ever empty, it's a sure sign that something went wrong somewhere, because the user should not be able to reach such a state via the UI. One sure way to reach that state was via the demo data, however, which had no start and end dates. This is now fixed. The situation for the variable period fields is similar. These fields should never be empty when the membership type is variable, and it's not typically possible to empty these values via the UI. For convenience's sake, I simply set them to required an sich, with a default value. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: vertical-association-16.0/vertical-association-16.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_extension/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: vertical-association-16.0/vertical-association-16.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_extension/
… and removed data file and its reference in manifest
Currently translated at 100.0% (65 of 65 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_extension/it/
Currently translated at 100.0% (65 of 65 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_extension/es/
Currently translated at 100.0% (65 of 65 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_extension/fr/
Currently translated at 100.0% (65 of 65 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_extension/it/
Currently translated at 16.9% (11 of 65 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_extension/pt_BR/
Currently translated at 41.5% (27 of 65 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_extension/ca/
Currently translated at 95.3% (62 of 65 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_extension/ca/
Currently translated at 95.3% (62 of 65 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_extension/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: vertical-association-17.0/vertical-association-17.0-membership_extension Translate-URL: https://translation.odoo-community.org/projects/vertical-association-17-0/vertical-association-17-0-membership_extension/
Don't return before consuming whole recordset.
Replaced by action_post(): https://github.com/odoo/odoo/blob/14.0/addons/account/models/account_move.py#L2681 So we rarely get the state updated on the membership line. Especially on creditnotes
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.