Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better performance of export for ARES #737

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

ganisimov
Copy link

Concept reports were generated and saved to files one by one for each concept_id. Here reports are generated as single data frame in one go. This way generation of reports is much faster.

@ganisimov
Copy link
Author

Added commit which applies similar approach to performTemporalCharacterization()

@ganisimov
Copy link
Author

Rebased over latest changes in develop branch to stay in sync

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 611 lines in your changes are missing coverage. Please review.

Comparison is base (0d486d1) 14.29% compared to head (34ac680) 0.00%.

❗ Current head 34ac680 differs from pull request most recent head dec19dc. Consider uploading reports for the commit dec19dc to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #737       +/-   ##
===========================================
- Coverage    14.29%   0.00%   -14.30%     
===========================================
  Files           14      14               
  Lines         3254    3649      +395     
===========================================
- Hits           465       0      -465     
- Misses        2789    3649      +860     
Files Coverage Δ
R/performTemporalCharacterization.r 0.00% <0.00%> (ø)
R/exportToAres.R 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fdefalco fdefalco merged commit 5fdd05c into OHDSI:develop Oct 9, 2023
2 checks passed
@ganisimov ganisimov deleted the export-performance branch October 10, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants