Developers Read Me file added #483
Conversation
extras/DevelopersREADME.md
Outdated
|
|
||
| c.Using the CDMConnector package: | ||
|
|
||
| i. Download a sample OMOP CDM into a DuckDB database, as documented here |
There was a problem hiding this comment.
this formatting got messed up; it's rendering as code instead of sub-bullets. also make sure to add in the hyperlinks out to CDMConnector docs on each line.
extras/DevelopersREADME.md
Outdated
|
|
||
| b. Create a new database in localhost for your test CDM, and create a schema in that database for the CDM tables | ||
|
|
||
| c.Using the CDMConnector package: |
There was a problem hiding this comment.
add space between c. and the text
extras/DevelopersREADME.md
Outdated
|
|
||
| i. Download a sample OMOP CDM into a DuckDB database, as documented here | ||
| ii. Copy the CDM into your local Postgres database, as documented here | ||
| 3.Fork the DataQualityDashboard repo |
There was a problem hiding this comment.
add space between 3. and the text
extras/DevelopersREADME.md
Outdated
| ii. Copy the CDM into your local Postgres database, as documented here | ||
| 3.Fork the DataQualityDashboard repo | ||
|
|
||
| 4.Clone your fork to your computer |
There was a problem hiding this comment.
add space between 4. and the text
|
closing in favor of #488 |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
- Coverage 85.95% 85.47% -0.48%
==========================================
Files 15 15
Lines 847 847
==========================================
- Hits 728 724 -4
- Misses 119 123 +4 ☔ View full report in Codecov by Sentry. |
|
replaced by #488 |
Before you do a pull request, you should always file an issue and make sure the package maintainer agrees that it's a problem, and is happy with your basic proposal for fixing it. We don't want you to spend a bunch of time on something that we don't think is a good idea.
Additional requirements for pull requests:
Adhere to the Developer Guidelines as well as the OHDSI Code Style.
If possible, add unit tests for new functionality you add.
Restrict your pull request to solving the issue at hand. Do not try to 'improve' parts of the code that are not related to the issue. If you feel other parts of the code need better organization, create a separate issue for that.
Make sure you pass R check without errors and warnings before submitting.
Always target the
developbranch, and make sure you are up-to-date with the develop branch.