Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #501

Merged
merged 5 commits into from
Nov 4, 2023
Merged

Small fixes #501

merged 5 commits into from
Nov 4, 2023

Conversation

katy-sadowski
Copy link
Collaborator

@katy-sadowski katy-sadowski commented Nov 3, 2023

Address #410 and #475 by allowing multiple CDM_SOURCE rows (and choosing a random one to populate the DQD metadata). A warning will be shown so users are aware of this.

Fix some small things in sqlOnly mode to enforce that "incremental mode" is only relevant when sqlOnly = TRUE.

Removes unnnecessary param in DB-to-JSON function.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ef06bfc) 86.49% compared to head (1998c32) 85.74%.

❗ Current head 1998c32 differs from pull request most recent head 460ffb1. Consider uploading reports for the commit 460ffb1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #501      +/-   ##
===========================================
- Coverage    86.49%   85.74%   -0.75%     
===========================================
  Files           16       16              
  Lines          881      884       +3     
===========================================
- Hits           762      758       -4     
- Misses         119      126       +7     
Files Coverage Δ
R/runCheck.R 96.55% <100.00%> (ø)
R/writeDBResultsTo.R 100.00% <100.00%> (ø)
R/executeDqChecks.R 88.33% <40.00%> (-3.10%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katy-sadowski katy-sadowski changed the title Katy warnings Small fixes Nov 4, 2023
@katy-sadowski katy-sadowski merged commit eb295b0 into OHDSI:develop Nov 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant