Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameter for checkSeverity #576

Closed
wants to merge 0 commits into from
Closed

Conversation

ob325
Copy link

@ob325 ob325 commented Oct 27, 2024

hades hackathon enhancement for #538

@katy-sadowski
Copy link
Collaborator

@ob325 thank you so much for this contribution! It was wonderful meeting you at the hackathon and I really appreciate you following through on this PR 😄

I think the changes all look good. There are just 2 things left to do before we can merge this in:

  • R CMD Check is throwing a warning because the docs need to be regenerated. If you run devtools::document() in the R console within the project, that should fix the warning
  • It'd also be great to update our vignette with info about the new parameter. I'm thinking you could just add a couple lines here showing how to set the checkSeverity parameter, and add it to the executeDqChecks function call:
    # which CDM tables to exclude? ------------------------------------
    tablesToExclude <- c("CONCEPT", "VOCABULARY", "CONCEPT_ANCESTOR", "CONCEPT_RELATIONSHIP", "CONCEPT_CLASS", "CONCEPT_SYNONYM", "RELATIONSHIP", "DOMAIN") # list of CDM table names to skip evaluating checks against; by default DQD excludes the vocab tables
    # run the job --------------------------------------------------------------------------------------
    DataQualityDashboard::executeDqChecks(connectionDetails = connectionDetails,
    cdmDatabaseSchema = cdmDatabaseSchema,
    resultsDatabaseSchema = resultsDatabaseSchema,
    cdmSourceName = cdmSourceName,
    cdmVersion = cdmVersion,
    numThreads = numThreads,
    sqlOnly = sqlOnly,
    sqlOnlyUnionCount = sqlOnlyUnionCount,
    sqlOnlyIncrementalInsert = sqlOnlyIncrementalInsert,
    outputFolder = outputFolder,
    outputFile = outputFile,
    verboseMode = verboseMode,
    writeToTable = writeToTable,
    writeToCsv = writeToCsv,
    csvFile = csvFile,
    checkLevels = checkLevels,
    tablesToExclude = tablesToExclude,
    checkNames = checkNames)

Let me know if those additions sound doable to you! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants