Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CharlsonIndex.sql per #160 #161

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sfortin1
Copy link

@sfortin1 sfortin1 commented May 4, 2022

New CCI coding algorithm per #160.

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #161 (a279136) into develop (fdfd9b7) will increase coverage by 70.18%.
The diff coverage is 94.05%.

@@             Coverage Diff              @@
##           develop     #161       +/-   ##
============================================
+ Coverage    23.28%   93.47%   +70.18%     
============================================
  Files           13       15        +2     
  Lines         1095     1165       +70     
============================================
+ Hits           255     1089      +834     
+ Misses         840       76      -764     
Impacted Files Coverage Δ
R/Aggregation.R 100.00% <ø> (+100.00%) ⬆️
R/FeatureExtraction.R 60.00% <ø> (+40.00%) ⬆️
R/GetCovariates.R 89.85% <ø> (+27.53%) ⬆️
R/GetDefaultCovariates.R 75.00% <ø> (+2.41%) ⬆️
R/Normalization.R 100.00% <ø> (+27.67%) ⬆️
R/CovariateData.R 88.15% <66.66%> (+78.69%) ⬆️
R/DefaultCovariateSettings.R 94.44% <66.66%> (+0.32%) ⬆️
R/DefaultTemporalCovariateSettings.R 94.44% <66.66%> (+0.32%) ⬆️
R/DefaultTemporalSequenceCovariateSettings.R 94.44% <94.44%> (ø)
R/UnitTestHelperFunctions.R 95.34% <95.34%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5363f5f...a279136. Read the comment docs.

@gowthamrao
Copy link
Member

Maybe easier to maintain if a reference table is created (like a csv with fields comorbidityId, conceptId). Store the csv file in the package path, read to memory as data frame, bulk load to db, perform inner join? Reason - may make the maintaining easier.

The advantage of the old approach of using ancestor_concept_id + descendants was it was more resistant to vocabulary changes. This change, that involves specifying each of the descendantConceptIds is more susceptible to vocabulary changes.

@anthonysena anthonysena modified the milestone: v4.0.0 Jun 20, 2022
@anthonysena anthonysena linked an issue Jan 10, 2023 that may be closed by this pull request
Comment on lines +587 to +594
WHERE descendant_concept_id IN (4160276, 443392, 4131422, 4131428, 4131304, 4130839,
4131938, 4133007, 4130842, 443252, 439392, 193144, 4312802,
78097, 4246450, 4246451, 378087, 4312290, 140960, 4247962,
192568, 4312023, 200959, 439751, 196053, 200348, 46273652,
4281027, 198700, 44806773, 254591, 318096, 442182, 320342,
434298, 434875, 373425, 199752, 72266, 4147162, 253717,
4315806, 196925, 46270513, 4281030, 136354, 198371, 4314071,
4158910, 78987, 432851)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfortin1 this list includes 439392, Primary malignant neoplasm. is that supposed to be an excluded concept?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated Charlson Comorbidity Score algorithm
4 participants