Skip to content

Commit

Permalink
Merge pull request #233 from OHDSI/develop
Browse files Browse the repository at this point in the history
Release V 2.1.2
  • Loading branch information
azimov authored Feb 13, 2024
2 parents f3dc393 + 9cecd7a commit 1c0db9e
Show file tree
Hide file tree
Showing 25 changed files with 2,968 additions and 693 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: OhdsiShinyModules
Type: Package
Title: Repository of Shiny Modules for OHDSI Result Viewers
Version: 2.1.1
Version: 2.1.2
Author: Jenna Reps
Maintainer: Jenna Reps <[email protected]>
Description: Install this package to access useful shiny modules for building shiny apps to explore results using the OHDSI tools .
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
OhdsiShinyModules v2.1.2
========================
Fixed bug in cohort diagnostics incidence rate plots not showing for different strata

OhdsiShinyModules v2.1.1
========================
Fixed bug in cohort diagnostics load up of orphan concepts server causing app to crash on load
Expand Down
8 changes: 6 additions & 2 deletions R/characterization-dechallengeRechallenge.R
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,10 @@ characterizationDechallengeRechallengeServer <- function(
connectionHandler = connectionHandler,
resultDatabaseSettings = resultDatabaseSettings
)
print(result)
failData(result)
# module to show failed plots

if(nrow(result) > 0){
shiny::showModal(
shiny::modalDialog(
title = paste0("Failed Plots: "),
Expand All @@ -203,6 +204,9 @@ characterizationDechallengeRechallengeServer <- function(
footer = NULL
)
)
} else{
showNotification("No fails to display")
}
}
}
})
Expand Down Expand Up @@ -292,7 +296,7 @@ getDechalRechalInputsData <- function(

shiny::withProgress(message = 'Extracting DECHALLENGE_RECHALLENGE data', value = 0, {

sql <- "SELECT d.CDM_SOURCE_ABBREVIATION as database_name, dr.*
sql <- "SELECT distinct d.CDM_SOURCE_ABBREVIATION as database_name, dr.*
FROM @schema.@c_table_prefixDECHALLENGE_RECHALLENGE dr
inner join @schema.@database_table d
on dr.database_id = d.database_id
Expand Down
Loading

0 comments on commit 1c0db9e

Please sign in to comment.