Skip to content

Commit

Permalink
Fixing #300 (#329)
Browse files Browse the repository at this point in the history
* Fixing #300

Syntax error in code was causing an issue in the rule sequencing, leading to incorrect attrition values. thanks to @chrisknoll for all the help

* fixing R check

fixing R check and removing a pointless file

---------

Co-authored-by: jreps <[email protected]>
  • Loading branch information
nhall6 and jreps authored Sep 19, 2024
1 parent 677d6b7 commit 258a786
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion R/cohort-generator-main.R
Original file line number Diff line number Diff line change
Expand Up @@ -927,7 +927,7 @@ getCohortGenerationAttritionTable <- function(
cohortRules <- rules %>%
dplyr::filter(.data$cohortDefinitionId==cohortId) %>%
dplyr::select("ruleSequence", "ruleName", "cohortName") %>%
dplyr::arrange("ruleSequence")
dplyr::arrange(.data$ruleSequence)

testMask = 0

Expand Down Expand Up @@ -967,6 +967,7 @@ getCohortGenerationAttritionTable <- function(
}

attritionTableDistinct <- dplyr::distinct(attritionTable)


#adding drop counts
attritionTableFinal <- attritionTableDistinct %>%
Expand Down

0 comments on commit 258a786

Please sign in to comment.