Skip to content

Commit

Permalink
custom spinner fix
Browse files Browse the repository at this point in the history
removing deps that are not in description and removing function that does not exist
  • Loading branch information
jreps committed Aug 5, 2024
1 parent 3bad639 commit 8687255
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Imports:
rmarkdown,
scales,
shiny,
shinycssloaders,
shinycssloaders (>= 1.1.0),
shinydashboard,
shinyglide,
shinyWidgets,
Expand Down
10 changes: 5 additions & 5 deletions R/helpers-customCSSLoader.R
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ buildSpinnerCustom <- function(
}

if (is.null(id)) {
id <- paste0("spinner-", digest::digest(ui_element))
id <- paste0("spinner-", sample(10000000,1)) # removed digest since not in dep
}

css_rules_tag <- get_spinner_css_tag(type, color, size, color.background, custom.css, id, image, caption, output_spinner)
Expand Down Expand Up @@ -158,8 +158,8 @@ withSpinnerCustom <- function(
stop("`ui_element` must be a Shiny tag", call. = FALSE)
}

spinner <- shinycssloaders::buildSpinner(
spinner_type = "output",
spinner <- shinycssloaders::withSpinner(
#spinner_type = "output",
ui_element = ui_element,
type = type,
color = color,
Expand All @@ -171,8 +171,8 @@ withSpinnerCustom <- function(
image = image,
image.width = image.width,
image.height = image.height,
hide.ui = hide.ui,
caption = caption
hide.ui = hide.ui#,
#caption = caption
)

htmltools::attachDependencies(spinner, getDependencies())
Expand Down

0 comments on commit 8687255

Please sign in to comment.