-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Modules into standardization
-starting to restructure sccs
Issue 95
- adding a component module for the input selection and selected view - testing component in the meta module
- updating incidence rate table
- adding conditional panel to meta results
Adding markdown to Depends of Description
Remove browser() call
fixing check issues
fixing test errors
- updated SCCS module - fixes multiple selection in input select component
fixing checks
- adding extra char types
fixing bug with diagnostic due to missing database_id in join
adding covariate name to sccs diag
fixing big with sccs diagnostic single view
- replaced plp design and model buttons with action dropdown button - updated tests - renamed tablePrefix to plpTablePrefix in Prediction to prepare for shared settings object across modules - renamed mySchema to schema in Prediction to standardized and prepare for shared settings object across modules
… and connection handlers, small update to components
adding some updates to main to phevaluator before merging into develop
Adding phevaluator and datasources modules to develop. Also improving tests and components module.
- renamed description to characterization - renamed estimation to cohort-method - updated inputs to prediction
- updating modules so they all use the same inputs in resultDatabaseSettings (this can now be shared across modules) - updating names to match analysis package names
updated interface
updated interface
- minor updates to cohort diagnostic to enable shared database table
updating version
* Index event breakdown report added to select input navigation * database selection in cd time distribution tab * database name in cohort diagnostics cohort counts simple tab
* Started large table component - mostly working. TOODO: - Unit tests - Inclusion in modules (characterization and cohort diagnostics) - Download data functionality (implement promises callback?) - Make appearance as close to other tables as possible - Allow row selection callback - Allow as many customisable reactable options as possible (beyond search and filters which will not easily work) - Make more compatible with query namespeaces to automatically generate advanced column filters * Tests and fully operational tables * Tests and fully operational tables * docs * docs * example fixed * example fixed * example fixed * example fixed * Changes to appearance * Changes to appearance * Minor fixes for appearance * Minor fixes for appearance * Columns now parameter to compnenent not data object, convenient creation function for ldts * Columns now parameter to compnenent not data object, convenient creation function for ldts * first CD ldt now mostly working - just some minor tweaks on first table to add * first CD ldt now mostly working - just some minor tweaks on first table to add * fixed typo in tests * fixed typo in tests * fixed typo in tests * fixed typo in tests * Minor changes to table * Minor changes to table * SOlution for query that works but not if database t1 is empty * SOlution for query that works but not if database t1 is empty * selected descedning results by default * selected descedning results by default * working tables * working tables * test change * test change * docs fix
- standardizing cohort method
- standardizing sccs
fixing merge of standardization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.