Standardization #180
Merged
Standardization #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Modules into standardization
…Modules into standardization
- updating SCCS table to use component - fixing cohort generator test fails
Codecov Report
@@ Coverage Diff @@
## develop #180 +/- ##
===========================================
+ Coverage 80.76% 82.62% +1.86%
===========================================
Files 66 70 +4
Lines 15910 17033 +1123
===========================================
+ Hits 12849 14073 +1224
+ Misses 3061 2960 -101
|
- adding selection options to SCCS diagnostics
- added summary diagnostic to CM and SCCS
- added evidence synth diagnostics
- adding some sticky columns to make it easier to explore results
removing shared_balance_diagnostic from diagnostics
- replaced plp design and model buttons with action dropdown button - updated tests - renamed tablePrefix to plpTablePrefix in Prediction to prepare for shared settings object across modules - renamed mySchema to schema in Prediction to standardized and prepare for shared settings object across modules
- renamed description to characterization - renamed estimation to cohort-method - updated inputs to prediction
- updating modules so they all use the same inputs in resultDatabaseSettings (this can now be shared across modules) - updating names to match analysis package names
updated interface
updated interface
- minor updates to cohort diagnostic to enable shared database table
updating version
- standardizing cohort method
- standardizing sccs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed cohort generator module for attrition table and attrition plot. This module still needs to add in the standard data table components module for all tables, but pulling for now to get a working version out there