Ldt cd characterization #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TOODO: - Unit tests - Inclusion in modules (characterization and cohort diagnostics) - Download data functionality (implement promises callback?) - Make appearance as close to other tables as possible - Allow row selection callback - Allow as many customisable reactable options as possible (beyond search and filters which will not easily work) - Make more compatible with query namespeaces to automatically generate advanced column filters
…ion function for ldts
…ion function for ldts
…t-cd-characterization # Conflicts: # R/cohort-diagnostics-characterization.R # R/components-largeTableViewer.R
Codecov Report
@@ Coverage Diff @@
## develop #195 +/- ##
===========================================
+ Coverage 86.91% 87.06% +0.15%
===========================================
Files 74 75 +1
Lines 16976 17221 +245
===========================================
+ Hits 14754 14993 +239
- Misses 2222 2228 +6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a component module and viewer for creating tables around very large queries (e.g. 50,000 + rows) which normally causes reactable to crash.
This paginates the results on the server using LIMIT and OFFSET parameter.
Note that this will only be supported by some database platforms (e.g. postgresql, sqlite, redshift and maybe some others) but not sql server which requires an "ORDER BY" clause to do off setting.
Please see the fully executable example in extras/examples/largeTables.R.
A note on the implementation: I created and R6 class LargeDataTable around this that could be subclassed if you wanted to use something that isn't a connection handler. For example, you could query a webApi instance with http requests or a large CSV file. This implementation shouldn't be too hard so if that happens I can create some more classes around that.
Once we agree the API for this is good enough I will add it to the CohortDiagnostics and Characterization modules as well as anywhere else with tables that frequently break apps.
Includes cohort diagnostics working large table code