updating incidence to merge in Nates edits #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jreps
commented
Sep 23, 2023
jreps
commented
- updated component input selection to enable div or other UIs that don't have an input
- update input selection to add a reset function (use updateFunction to specify the update function name)
- added Nate's formatting to add selected options on new lines
- updated Nate's incidence rate module to use standard input selection
- updated component input selection to enable div or other UIs that don't have an input - update input selection to add a reset function (use updateFunction to specify the update function name) - added Nate's formatting to add selected options on new lines - updated Nate's incidence rate module to use standard input selection
azimov
approved these changes
Sep 26, 2023
| if (cur_dev > 1) grDevices::dev.set(cur_dev) | ||
| }) | ||
| # Convert to ggplot------------- | ||
| cowplot::ggdraw() + |
There was a problem hiding this comment.
Just confirming that this package is added to develop?
Adding it was necessary as pulling the legend out of the plot and placing it below was very difficult without this.
|
Just a few build warnings and 1 failed test, otherwise this looks good |
fixing incidence rate tar bug
fixing R check
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #201 +/- ##
===========================================
- Coverage 79.35% 78.56% -0.80%
===========================================
Files 72 72
Lines 17135 17803 +668
===========================================
+ Hits 13598 13987 +389
- Misses 3537 3816 +279
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.