Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding phevaluator module functionality and colDefs for all reactables per new result model spec #209

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

nhall6
Copy link
Collaborator

@nhall6 nhall6 commented Oct 11, 2023

No description provided.

@nhall6 nhall6 requested a review from jreps October 11, 2023 14:46
nhall6 and others added 5 commits October 18, 2023 16:40
…) function, ensuring plot will work if no trellises are selected
CG: when cohort inclusion and attrition results are not present, show proper and clean shiny message to the user

Incidence: All standard plots updated
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (99422f4) 78.56% compared to head (b35796a) 78.49%.
Report is 17 commits behind head on main.

Files Patch % Lines
R/characterization-incidence.R 19.56% 74 Missing ⚠️
R/phevaluator-main.R 75.00% 10 Missing ⚠️
R/cohort-diagnostics-definition.R 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   78.56%   78.49%   -0.08%     
==========================================
  Files          72       72              
  Lines       17803    17828      +25     
==========================================
+ Hits        13987    13994       +7     
- Misses       3816     3834      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jreps
Copy link
Collaborator

jreps commented Jan 22, 2024

@nhall6 is this pull request still needed?

@nhall6
Copy link
Collaborator Author

nhall6 commented Jan 23, 2024

@nhall6 is this pull request still needed?

Yes I believe so. But we can merge into develop instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants