Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #218

Merged
merged 9 commits into from
Nov 28, 2023
Merged

Develop #218

merged 9 commits into from
Nov 28, 2023

Conversation

jreps
Copy link
Collaborator

@jreps jreps commented Nov 28, 2023

  • edited characterization server to work with new aggregate features method in characterization package
  • edited characterization server to work when one or more characterization result is missing
  • edited evidence synth module to highlight the bayesian and fix issue with comparison names not showing

azimov and others added 9 commits November 2, 2023 10:51
- updating evidence synth code
- updated characterization to only show tabs if there are results tables for the tabs
- also made it so the characterization servers only load when the tab is selected for the first time
- updated tests for characterization
- updated tests for previous evidence synth edits
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (99422f4) 78.56% compared to head (469c587) 78.45%.
Report is 17 commits behind head on main.

Files Patch % Lines
R/characterization-incidence.R 0.00% 36 Missing ⚠️
R/evidence-synth-sccs.R 92.99% 25 Missing ⚠️
R/evidence-synth-cm.R 98.63% 5 Missing ⚠️
R/cohort-diagnostics-definition.R 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   78.56%   78.45%   -0.11%     
==========================================
  Files          72       74       +2     
  Lines       17803    18003     +200     
==========================================
+ Hits        13987    14125     +138     
- Misses       3816     3878      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jreps jreps merged commit ff29ffe into main Nov 28, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants