Fixing #302 and Filtered Data Downloads #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All filtered data downloads across all modules should work now, with a button styled the same as the full download. It needs to be a CSV handler though due to the reactable statte
nhall6
added
bug
Also fixed download buttons in Cohorts module, addressing #298
|
@conovermitch - In this same PR I have now also fixed #298 |
jreps
added a commit
that referenced
this pull request
Sep 19, 2024
* Fixing #301 (#326) Adding alphabetical sort to DB input options * Fixing #296 (#327) Standardizing pickerInput type for database selection where multiple options are possible to improve UX. Also fixed some colDefs in Exposed Cases * Fixing #302 and Filtered Data Downloads (#332) * Fixing #302 and Filtered Data Downloads All filtered data downloads across all modules should work now, with a button styled the same as the full download. It needs to be a CSV handler though due to the reactable statte * Updating the fix Also fixed download buttons in Cohorts module, addressing #298 * Update R_CMD_check_Hades.yaml * Update R_CMD_check_Hades.yaml * Update R_CMD_check_Hades.yaml * fixing R checks fixing R checks * Update cohort-diagnostics-databaseInformation.R (#333) Fixing the issue reported in #162 * fixing issue issue_330 (#334) fixing time plot x-axis * fixing issue 167 (#335) added code to get long database names on multiple lines * Update cohort-diagnostics-timeDistributions.R (#336) adding fix for issue 168 * Update patient-level-prediction-modelSummary.R (#337) --------- Co-authored-by: Nathan Hall <[email protected]>
jreps
added a commit
that referenced
this pull request
Sep 20, 2024
* Fixing Power tables re: #114 Standardizing power table outputs to adhere to OSM standard theme (reactable via resultTableViewer and resultTableServer). Also split the tables into 2 sub-tabs for easier readability * Updating propensity score table Adding conditional formatting of colors to values to aid in interpretation, and also adding an absolute value of beta column. * Updates to propensity score plot Overlaying equipoise statistic onto the plot, and truncating cohort names in legend * Updating covariate balance plot Adding maxSDM to covariate balance plot * Updating captions and systematic error Adding to caption descriptions in figures and overlaying EASE statistic on systematic error plot * Updating systematic error Adding more descriptive filenames for plot downloads * Develop (#340) * Fixing #301 (#326) Adding alphabetical sort to DB input options * Fixing #296 (#327) Standardizing pickerInput type for database selection where multiple options are possible to improve UX. Also fixed some colDefs in Exposed Cases * Fixing #302 and Filtered Data Downloads (#332) * Fixing #302 and Filtered Data Downloads All filtered data downloads across all modules should work now, with a button styled the same as the full download. It needs to be a CSV handler though due to the reactable statte * Updating the fix Also fixed download buttons in Cohorts module, addressing #298 * Update R_CMD_check_Hades.yaml * Update R_CMD_check_Hades.yaml * Update R_CMD_check_Hades.yaml * fixing R checks fixing R checks * Update cohort-diagnostics-databaseInformation.R (#333) Fixing the issue reported in #162 * fixing issue issue_330 (#334) fixing time plot x-axis * fixing issue 167 (#335) added code to get long database names on multiple lines * Update cohort-diagnostics-timeDistributions.R (#336) adding fix for issue 168 * Update patient-level-prediction-modelSummary.R (#337) --------- Co-authored-by: Nathan Hall <[email protected]> * fixing testing errors --------- Co-authored-by: jreps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All filtered data downloads across all modules should work now, with a button styled the same as the full download. It needs to be a CSV handler though due to the reactable state