Merge pull request #49 from OHDSI/develop

Release 0.5.4
OHDSI · Dec 15, 2023 · 4a3af3a · 4a3af3a
2 parents ebfaf9c + 5b10f19
commit 4a3af3a
Show file tree

Hide file tree

Showing 38 changed files with 307 additions and 251 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: ResultModelManager
 Title: Result Model Manager (RMM) for OHDSI packages
-Version: 0.5.4
+Version: 0.5.5
 Authors@R:
     person("Jamie", "Gilbert", , "[email protected]", role = c("aut", "cre"))
 Description: Database data model management utilities for OHDSI packages.
@@ -39,5 +39,6 @@ Suggests:
   devtools,
   pkgdown,
   remotes,
-  styler
+  styler,
+  Andromeda
 Config/testthat/edition: 3
diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,13 @@
-# ResultModelManager 0.5.3
+# ResultModelManager 0.5.5
+
+Bug Fixes:
+1. Removal of comment in  DataMigrationManager sql that caused translation error for spark/databricks platforms
+
+2. The "optional" column in the model specification is now fully optional (when not present, all columns are assumed to
+be required)
+
+
+# ResultModelManager 0.5.4
 
 Changes:
 

diff --git a/R/DataMigrationManager.R b/R/DataMigrationManager.R
@@ -308,7 +308,7 @@ DataMigrationManager <- R6::R6Class(
       sql <- "
       --HINT DISTRIBUTE ON RANDOM
       CREATE TABLE @database_schema.@table_prefix@migration (
-          migration_file VARCHAR PRIMARY KEY, --string value represents file name
+          migration_file VARCHAR PRIMARY KEY,
           migration_order INT NOT NULL unique
       );"