-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception handling and timing for execution #149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ES upload bug
anthonysena
changed the base branch from
remove-deps-add-module-interface
to
v1.0-main
July 31, 2024 15:31
anthonysena
changed the title
Initial exception handling for execution
Exception handling and timing for execution
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to address #141 to provide better exception handling for execution. This work depends on the completion of #145. I've provided a reprex below to show how this is currently working.
A few notes:
purrr::safely
works nicely to capture errors and to provide a summary of the entirety of the execution. The only potential downside is that we don't seem to get a stack trace (but this may be due to my contrived example that will eventually be the basis for a test case).execute
function such that we may want to stop upon an error.Reprex
Created on 2024-07-16 with reprex v2.1.0