V1.0 plpv mt modules #171
Open
V1.0 plpv mt modules #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much @egillax! I'm working to get the v1.0 release completed and then will work with you to get this into a v1.1 shortly thereafter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@anthonysena,
I've updated the plp validation module and model transfer module. I also got the test working for the plp validation module, run is here.
Triggered by your review comment I realized the logic was flawed in the validation module in how models are matched to validation problems. I fixed that in a way that will work for many studies (my PandemicPrediction included), but for complete flexibility I think the model transfer functionality needs to be added to the PLP package (tracked here)
I did need two changes not directly relevant to get the CI to run. One to comment out a debug command and the other to upgrade the upload artifacts action. But I can rebase them out before merging or whatever you prefer.