Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use ATLAS Pathways SQL #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

katy-sadowski
Copy link
Contributor

  • Adds the original Pathways SQL query from ATLAS, and a parameter in createTxHistoryTable that lets the user choose this or the default query. Defaults to default to avoid a breaking change
    • Users will need to re-run their code from the start once the update the package, but won't need to update any code
  • Adds warnings in spots where the ATLAS output is not suitable (i.e., when end dates are used in the analysis). The ATLAS approach collapses all dates, including end dates in certain cases, so its end dates are not usable in analysis
  • Adds documentation about the 2 approaches
  • Resolves R CMD Check WARNINGs. There are still lots of NOTEs to clean up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant