Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

September Updates #252

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

September Updates #252

wants to merge 4 commits into from

Conversation

denyskaduk
Copy link
Contributor

No description provided.

drop table if exists upd_conc;
create table upd_conc as
select distinct concept_code_1,vocabulary_id_1,cr.concept_id_2, 1
from relationship_to_concept rtc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any check whether the target concept is standard ('Concept replaced by' can point to a non-standard one and be followed with another 'Concept replaced by')?

)
SELECT q_code,
concept_code_1,
(TRIM(d1)::FLOAT) / 5 *volume,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add comment here? I'm assuming d1/5*volume is for tablespoons, but don't see how you pick only tablespoons.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for response, I added comment for this case.

Copy link
Contributor

@aostropolets aostropolets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall suggestion to submit a comment including a temporary table/file with a delta of current vocabulary run (e.g. what concepts in GRR and RxE got deprecated/updated/created).

@denyskaduk
Copy link
Contributor Author

Overall suggestion to submit a comment including a temporary table/file with a delta of current vocabulary run (e.g. what concepts in GRR and RxE got deprecated/updated/created).

This vocabulary with requested license for view, I think we can't add any kind of source information here(e.g. GRR concepts). If you want to look on changes that was done, you can find all stage tables in vocabulary schema

@aostropolets
Copy link
Contributor

You don’t have to submit table here. The name of the table in the schema will work (it should contain both grr and rxe concepts that have undergone changes)

@Alexdavv Alexdavv mentioned this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants