-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ciel update #548
base: master
Are you sure you want to change the base?
Ciel update #548
Conversation
Hi @hardhouse and @Alexdavv , I just noticed that from line 413 on there is still coding that is drug relevant (RxNorm, resolving MIN to IN etc.). Is all of this still relevant coding or should some of it be silenced? MINs now exist in the vocabulary, although only as non-standard, but I understand that this would be resolved in the generic update while the stage tables are being processed? relationships between SNOMED and RxNorm probably still make sense, but I thought they exist anyway independently from CIEL... |
Hi @hardhouse , I found a potential inconsistency where the coding seems to fail picking up the "preferred" concept name: SELECT * FROM dev_ciel.concept_stage
WHERE concept_code = '104048';
SELECT * FROM dev_ciel.ciel_concept_name
WHERE concept_id = 104048
AND locale = 'en'
AND locale_preferred = 1;
Or maybe this is related to the not silenced code parts? |
concept names come from p3 Vocabulary-v5.0/CIEL/load_stage.sql Line 50 in a1f88f9
|
ah, okay. The section where we limit to locale = 'en' AND locale_preferred = 1 was meant to take care of that. (It seems I am quite lost in the code...) |
|
Generic update can't add the links, while it will definitely deprecate the links to non-standard. Some of the procedures can, but I still wouldn't stick to the logic that conflicts with the design. We add "Maps to" only to Standard concepts by the definition, while MINS are not. So yes, this code section seems to be needed.
Don't we add them to the temporary table only in order to support the logic? |
sorry... warming this up once more... Hi @hardhouse We have some mismatches that I contribute to the logic that happens besides the existing CIEL-RxN + SNOMED mappings (as mentioned above). There are only a couple of those and they come from the DrugClass and MedSet CIEL domains:
They do have mappings to SNOMED like this example shows: This provides us with the SNOMED code 108661002. But the mapping the logic had found is clearly wrong, as it seems to process some synonym containing the term "histamine" while it should be pointing at histamine-blocker (the opposite). As there are only very few correct entries from these domains, we might want to ignore them altogether, because they do not give us additional value. Can you find out where in the code we could exclude mapping those domains Drug Class and MedSet? |
@mik-ohdsi hi, just add these relationships to manual table (dev_ciel.concept_relationship_manual) as 'D', and the procedure ProcessManualRelationships() will do the rest |
Hi @hardhouse - I was almost certain I had created a comment here a while ago... but none to see... |
Hi @mik-ohdsi |
@hardhouse - I would hope there are no relationships created if we do not have a source code for it. We simply want to suppress all "source codes" of the classes Drug Class and MedSet. Maybe by excluding them from the "INSERT INTO concept_stage" ? |
no, that's not how it works |
wait, are you telling me we would create relationships in concept_relationship_stage for concepts that are not in concept_stage? It sounds weird to me that we would do that... well, only for the case that a relationship existed before and we want to remove it (which we added to the logic, if I am not mistaken)... now I am a little confused... |
hmm, it seems to me that there are a number of issues that need to be clarified:)
|
new logic for drugs