Fix putting constant on left side of equality operator

OHDSI · Jul 30, 2024 · 096e7ed · 096e7ed
1 parent aeaf260
commit 096e7ed
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/org/ohdsi/webapi/service/converters/SourceRequestToSourceConverter.java b/src/main/java/org/ohdsi/webapi/service/converters/SourceRequestToSourceConverter.java
@@ -29,7 +29,7 @@ public Source convert(SourceRequest request) {
         source.setKeyfileName(request.getKeyfileName());
         source.setKrbAdminServer(request.getKrbAdminServer());
         source.setKrbAuthMethod(KerberosAuthMechanism.getByName(request.getKrbAuthMethod()));
-        if (null != request.isCheckConnection()) {
+        if (request.isCheckConnection() != null) {
             source.setCheckConnection(request.isCheckConnection());
         }
         return source;

diff --git a/src/main/java/org/ohdsi/webapi/source/SourceController.java b/src/main/java/org/ohdsi/webapi/source/SourceController.java
@@ -238,7 +238,7 @@ public SourceInfo updateSource(@PathParam("sourceId") Integer sourceId, @FormDat
       }
       setKeyfileData(updated, source, file);
       transformIfRequired(updated);
-      if (null == request.isCheckConnection()) {
+      if (request.isCheckConnection() == null) {
         updated.setCheckConnection(source.isCheckConnection());
       }
       updated.setModifiedBy(getCurrentUser());