Merged in fixNPECharacterization (pull request #40)

Fixed NullPointerException during saving of a cohort characterization with missing design
OHDSI · Sep 4, 2024 · b669f55 · b669f55
2 parents accf315 + 7f7f196
commit b669f55
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/.../java/org/ohdsi/webapi/feanalysis/converter/FeAnalysisEntityToFeAnalysisDTOConverter.java b/.../java/org/ohdsi/webapi/feanalysis/converter/FeAnalysisEntityToFeAnalysisDTOConverter.java
@@ -2,12 +2,14 @@
 
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.commons.collections4.CollectionUtils;
 import org.ohdsi.analysis.cohortcharacterization.design.FeatureAnalysisAggregate;
 import org.ohdsi.webapi.feanalysis.domain.*;
 import org.ohdsi.webapi.feanalysis.dto.*;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
 
+import java.util.Collections;
 import java.util.List;
 import java.util.Objects;
 import java.util.Optional;
@@ -52,6 +54,9 @@ private Object convertDesignToJson(final FeAnalysisEntity source) {
             switch (type) {
                 case CRITERIA_SET:
                     FeAnalysisWithCriteriaEntity<?> sourceWithCriteria = (FeAnalysisWithCriteriaEntity<?>) source;
+                    if (CollectionUtils.isEmpty(sourceWithCriteria.getDesign())) {
+                        return Collections.emptyList();
+                    }
                     return sourceWithCriteria.getDesign()
                             .stream()
                             .map(this::convertCriteria)