-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up several libraries #2202
Bump up several libraries #2202
Conversation
- org.ehcache:ehcache 3.8.1 - javax.cache:cache-api 1.0.0 - commons-httpclient:commons-httpclient 3.1 Upgraded the following to versions provided by SPring Boot 2.7 -- org.apache.commons:commons-lang3 3.9 -> 3.12.0 -- com.google.code.gson:gson 2.8.9 -> 2.9.0 -- com.zaxxer:HikariCP 3.3.1 -> 4.0.3 -- com.microsoft.sqlserver:mssql-jdbc 9.2.1.jre8 -> 10.2.1.jre8
Our Spring Boot version seems to be 1.5 (at least according to this line in the pon):
Will these updates cause a conflict with the current version of spring boot? |
@chrisknoll I am aware we are on spring boot 1.5. Maybe the title of PR caused unnecessary concern. As you might know, spring bundles third-party version numbers of libraries usually paired with spring boot applications to provide features. So I identified the libraries listed in WebAPI that can safely be bumped so that when we arrive at the goal of being on Spring Boot 2.7.x and then we can remove the explicit versioning and let the listed versions listed in Spring Boot handle the upgrading of libraries instead of bumping libs individually. So yes, it is safe to update these libraries> I ran the unit test and the supplied integration tests and all ran to success. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(deleted)
These changes are related to upgrading WebAPI to Spring Boot 2.x |
* Removed the following unused libraries: - org.ehcache:ehcache 3.8.1 - javax.cache:cache-api 1.0.0 - commons-httpclient:commons-httpclient 3.1 Upgraded the following to versions provided by SPring Boot 2.7 -- org.apache.commons:commons-lang3 3.9 -> 3.12.0 -- com.google.code.gson:gson 2.8.9 -> 2.9.0 -- com.zaxxer:HikariCP 3.3.1 -> 4.0.3 -- com.microsoft.sqlserver:mssql-jdbc 9.2.1.jre8 -> 10.2.1.jre8 * Removing unnecessary comments.
Removed the following unused libraries:
Upgraded the following to versions provided by SPring Boot 2.7
-- org.apache.commons:commons-lang3 3.9 -> 3.12.0
-- com.google.code.gson:gson 2.8.9 -> 2.9.0
-- com.zaxxer:HikariCP 3.3.1 -> 4.0.3
-- com.microsoft.sqlserver:mssql-jdbc 9.2.1.jre8 -> 10.2.1.jre8