Allow to skip connection check for certain sources

[ganisimov]

Addresses #2359

[chrisknoll]

Looks good. Is there any other modifications you would want to make before we merge this PR?

[ganisimov]

@chrisknoll , the checkConnection() is used in API call /source/connection/{key} here:

WebAPI/src/main/java/org/ohdsi/webapi/source/SourceController.java

Line 348 in 6a43da5

sourceService.checkConnection(source);

So, I'm not sure if it's desired to suppress connection check here in any case. If the change was requested to optionally skip the check only when dealing with daimons (#2350), I would handle the setting closer to that code and not in checkConnection(). Do you have any thoughts on this?

[chrisknoll]

Seems like if the setting on the source is to disable check connections, then it's reasonable that all calls to check connection will just bypass. So, in the case you show here, you would want to bypass the check in all cases.

[ganisimov]

OK then I'm good with the changes, thanks!