Application usage statistics #2387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-odysseus
commented
Aug 27, 2024
|
|
||
| @Controller | ||
| @Path("/statistic/") | ||
| @ConditionalOnProperty(value = "audit.trail.enabled", havingValue = "true") |
There was a problem hiding this comment.
If Audit Trail feature is not enabled the Controller is not efficient
alex-odysseus
commented
Aug 27, 2024
| private StatisticService service; | ||
|
|
||
| public enum ResponseFormat { | ||
| CSV, JSON |
There was a problem hiding this comment.
Both CSV and JSON output formats should be supported
alex-odysseus
commented
Aug 27, 2024
| .header("Content-Disposition", String.format("attachment; filename=\"%s\"", filename)) | ||
| .build(); | ||
| } catch (Exception ex) { | ||
| throw new RuntimeException(ex); |
There was a problem hiding this comment.
We may add some logging here
alex-odysseus
commented
Aug 27, 2024
| } | ||
| } | ||
|
|
||
| private void updateExecutionStatisticsHeader(boolean showUserInformation) { |
There was a problem hiding this comment.
Both methods to be replaced by extra two static constants!
alex-odysseus
commented
Aug 27, 2024
| private String sourceName; | ||
| private String executionName; | ||
| private String executionDate; | ||
| private String userID; |
alex-odysseus
commented
Aug 27, 2024
| protected final Logger LOG = LoggerFactory.getLogger(getClass()); | ||
|
|
||
| @Value("${audit.trail.log.file}") | ||
| // TODO remove value |
There was a problem hiding this comment.
To be configured via properties
alex-odysseus
commented
Aug 27, 2024
| @@ -0,0 +1,2 @@ | |||
| UPDATE ${ohdsiSchema}.sec_permission SET value='statistic:executions:post' | |||
There was a problem hiding this comment.
We may combine both scripts into one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #2329
Business logic is based on parsing Audit Trail log entries. As some of the Analysis Execution entries were identified as duplicates a filter has been introduced to count each Analysis Execution precisely once
Usage examples (for the second one {} is used in the 'urlPattern' parameter to indicated a dynamic part of the URL):