Re-introduce Caching #2393
Open
Re-introduce Caching #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation uses ehCache 3.9. Added test for CohortDefinitionService caching.
Increased size of small-heap configuration.
Fixed permission tests.
Changed asset cache key to use login always due to read/write permissions being assigned at a per-user basis.
… (old style) when caching is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented caching for cohort def list, concept set list, permissions.
Implementation uses ehCache 3.9.
Added test for CohortDefinitionService caching.
Notes:
This implementation diverges from the sandbox: I decided to leverage
@CacheEvicton methods instead of JPA Entity Listeners to simplify the implementation.Currently getting cache info is unprotected, but cache/clear is protected.