chore: refactor dependencies #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused dependencies from requirements.txt - Add common requirements to requirements/common.in - Add duckdb requirements to requirements/duckdb.in - Add postgres requirements to requirements/postgres.in - Autogenerate requirements/duckdb.txt and requirements/postgres.txt using uv pip compile
katy-sadowski
requested changes
Sep 30, 2024
lawrenceadams
force-pushed
the
66-chore-cleanup-and-refactor-requirements
branch
from
5838c18
to
a9e4c89
Compare
README.md
Outdated
Comment on lines
37
to
44
| 4. In your virtual environment, install dbt and other required dependencies as follows: | ||
| ```bash | ||
| pip3 install -r requirements.txt | ||
| # choose requirements depending on which database you're targeting | ||
| pip3 install -r requirements/duckdb.txt | ||
| pip3 install -r requirements/postgres.txt | ||
| pre-commit install | ||
| ``` | ||
| - This will install dbt-core, the dbt duckdb and postgres adapters, SQLFluff (a SQL linter), pre-commit (in order to run SQLFluff on all newly-committed code in this repo), duckdb (to support bootstrapping scripts), and various dependencies for the listed packages |
There was a problem hiding this comment.
can remove this now! and maybe just add the specification that requirements needs to be installed in the virtual env (maybe obvious, but can't be too careful :))
There was a problem hiding this comment.
ahhh dim moment - thought I had!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the project's dependencies and requirements. It removes unused dependencies from the requirements.txt file and adds common requirements to requirements/common.in - allowing deterministic builds for devcontainers/codespaces/ci - and allowing easier updates of packages.
Compiled output requirement files are generated with
uv pip compile ...