Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpdk: collection of user-facing improvements v1 #12531

Closed

Conversation

lukashino
Copy link
Contributor

Lukas Sismis added 6 commits February 5, 2025 13:10
It turned out that having global (interface-specific) mempool
that is shared by the threads of the interface is slower than
having individual mempools per queue for each interface.

The commit brings this change and should be user-invisible,
the config setting remains still as a number of objects of
all mempools summed (of that interface).

Ticket: 7382
ICE card (Intel E810) was not receiving packets immediatelly
after startup, Suricata workers would act as processing while
it was not. This eliminates the problem by only continuing
in the initialization if the link is already up.

The setting can be turned off manually from the configuraiton
file.

Ticket: 7381
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 49.53704% with 109 lines in your changes missing coverage. Please review.

Project coverage is 80.67%. Comparing base (d4330ef) to head (9633462).
Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12531      +/-   ##
==========================================
- Coverage   80.68%   80.67%   -0.02%     
==========================================
  Files         925      926       +1     
  Lines      258914   259051     +137     
==========================================
+ Hits       208914   208980      +66     
- Misses      50000    50071      +71     
Flag Coverage Δ
fuzzcorpus 56.88% <ø> (+0.05%) ⬆️
livemode 19.42% <49.53%> (+0.01%) ⬆️
pcap 44.20% <ø> (+<0.01%) ⬆️
suricata-verify 63.37% <ø> (-0.02%) ⬇️
unittests 58.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24618

@victorjulien victorjulien added the needs rebase Needs rebase to master label Feb 11, 2025
@victorjulien
Copy link
Member

Needs rebase after recent merges

Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs rebase

@lukashino
Copy link
Contributor Author

rebased in #12571

@lukashino lukashino closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase Needs rebase to master
Development

Successfully merging this pull request may close these issues.

3 participants