Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpdk: collection of user-facing improvements v1.3 #12571

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lukashino
Copy link
Contributor

Follow-up of: #12531

Tickets:
https://redmine.openinfosecfoundation.org/issues/7373
https://redmine.openinfosecfoundation.org/issues/7382
https://redmine.openinfosecfoundation.org/issues/7381
https://redmine.openinfosecfoundation.org/issues/7380
https://redmine.openinfosecfoundation.org/issues/7374
https://redmine.openinfosecfoundation.org/issues/7373
https://redmine.openinfosecfoundation.org/issues/5838

v1.3:

  • rebased

Describe changes:

  • document vlan stripping offload
  • check for link-up before full startup
  • use the default iface-copy value if not specified
  • replace global with per-thread mempools
  • auto-configure Rx/Tx descriptors and mempool size

Lukas Sismis added 6 commits February 13, 2025 09:43
It turned out that having global (interface-specific) mempool
that is shared by the threads of the interface is slower than
having individual mempools per queue for each interface.

The commit brings this change and should be user-invisible,
the config setting remains still as a number of objects of
all mempools summed (of that interface).

Ticket: 7382
ICE card (Intel E810) was not receiving packets immediatelly
after startup, Suricata workers would act as processing while
it was not. This eliminates the problem by only continuing
in the initialization if the link is already up.

The setting can be turned off manually from the configuraiton
file.

Ticket: 7381
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 49.53704% with 109 lines in your changes missing coverage. Please review.

Project coverage is 80.69%. Comparing base (3831843) to head (1629000).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12571      +/-   ##
==========================================
- Coverage   80.72%   80.69%   -0.03%     
==========================================
  Files         929      930       +1     
  Lines      259062   259199     +137     
==========================================
+ Hits       209119   209165      +46     
- Misses      49943    50034      +91     
Flag Coverage Δ
fuzzcorpus 56.96% <ø> (+0.01%) ⬆️
livemode 19.41% <49.53%> (+0.01%) ⬆️
pcap 44.18% <ø> (-0.01%) ⬇️
suricata-verify 63.41% <ø> (+0.03%) ⬆️
unittests 58.36% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.uptime 636 667 104.87%

Pipeline 24716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants