Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename table of contents files #3424

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Rename table of contents files #3424

merged 7 commits into from
Nov 20, 2024

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Nov 15, 2024

What is the context of this PR?

Fixes: #3296

Renames the table of contents files to match the naming conventions of other similar files in the DS.

Also made some standardisation changes on the back to top component to bring them inline with js on other components

How to review this PR

  • Tests pass
  • Table of contents and back to top still render and work as expected with no changes to examples

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@rmccar rmccar added the Tech improvements Tech debt, cleanup, code standardisation etc. label Nov 15, 2024
@rmccar rmccar self-assigned this Nov 15, 2024
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 3e8f903
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/673e0062d0c2de0009b6f27e
😎 Deploy Preview https://deploy-preview-3424--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar rmccar added Breaking changes This PR contains at least one breaking change and removed Breaking changes This PR contains at least one breaking change labels Nov 19, 2024
@rmccar rmccar merged commit 4108db8 into main Nov 20, 2024
25 checks passed
@rmccar rmccar deleted the rename-table-of-contents-files branch November 20, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Rename DS table of contents files
3 participants