-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new "grey" hero variant #3450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/165/analysis-hero
Co-authored-by: rmccar <[email protected]>
Co-authored-by: rmccar <[email protected]>
admilne
reviewed
Dec 19, 2024
...data/bitmaps_reference/ds-vr-test__components_hero_example-hero-grey_0_document_1_tablet.png
Outdated
Show resolved
Hide resolved
...ata/bitmaps_reference/ds-vr-test__components_hero_example-hero-grey_0_document_0_desktop.png
Outdated
Show resolved
Hide resolved
admilne
approved these changes
Dec 20, 2024
Now this is called the "grey" variant the title and description should be updated |
rmccar
reviewed
Jan 6, 2025
rmccar
reviewed
Jan 6, 2025
rmccar
reviewed
Jan 6, 2025
rmccar
reviewed
Jan 6, 2025
rmccar
reviewed
Jan 10, 2025
The Breadcrumbs component was adding undefined to its classes when no class was provided in the example. So, I added default('') to it in the code. |
rmccar
reviewed
Jan 13, 2025
Would you be able to rewrite the description, it doesn't really describe the change |
Co-authored-by: rmccar <[email protected]>
rmccar
reviewed
Jan 13, 2025
rmccar
reviewed
Jan 13, 2025
Co-authored-by: rmccar <[email protected]>
rmccar
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
ONSDESYS-165....
Created new Hero variant as per the Figma.It has a grey background with logo on the right.
This new variant will also have Breadcrumbs, title, sub-header and horizontal description list(link to the PR)
Prototype link
Due to the changes in the HTML structure, I adjusted the styling by removing the margin applied to the text element when followed by a button. Instead, I added a margin to the top of the button to ensure consistent spacing.
How to review this PR
Check that new src/components/hero/example-hero-grey.njk in Hero component matches the figma design
Checklist
This needs to be completed by the person raising the PR.