Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new "grey" hero variant #3450

Merged
merged 60 commits into from
Jan 14, 2025
Merged

Add new "grey" hero variant #3450

merged 60 commits into from
Jan 14, 2025

Conversation

precious-onyenaucheya-ons
Copy link
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Dec 9, 2024

What is the context of this PR?

ONSDESYS-165....

Created new Hero variant as per the Figma.It has a grey background with logo on the right.

This new variant will also have Breadcrumbs, title, sub-header and horizontal description list(link to the PR)

Prototype link

Due to the changes in the HTML structure, I adjusted the styling by removing the margin applied to the text element when followed by a button. Instead, I added a margin to the top of the button to ensure consistent spacing.

How to review this PR

Check that new src/components/hero/example-hero-grey.njk in Hero component matches the figma design

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@rmccar
Copy link
Contributor

rmccar commented Jan 6, 2025

Now this is called the "grey" variant the title and description should be updated

@rmccar rmccar changed the title Feature/165/analysis hero Add new "grey" hero variant Jan 6, 2025
src/scss/vars/_colors.scss Outdated Show resolved Hide resolved
@SriHV
Copy link
Contributor

SriHV commented Jan 13, 2025

The Breadcrumbs component was adding undefined to its classes when no class was provided in the example. So, I added default('') to it in the code.

@rmccar
Copy link
Contributor

rmccar commented Jan 13, 2025

Would you be able to rewrite the description, it doesn't really describe the change

@SriHV SriHV merged commit 9e63499 into main Jan 14, 2025
28 checks passed
@SriHV SriHV deleted the feature/165/analysis-hero branch January 14, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Change of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants