Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new "grey" hero variant #3450

Merged
merged 60 commits into from
Jan 14, 2025
Merged
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
f4b1347
add inital changes
precious-onyenaucheya-ons Nov 27, 2024
349573c
approve vr tests
precious-onyenaucheya-ons Nov 27, 2024
52c7272
Merge branch 'main' into feature/189/add-horizontal-description-list
precious-onyenaucheya-ons Nov 27, 2024
22c7b5f
update as per PR comments
precious-onyenaucheya-ons Nov 28, 2024
79f772b
delete test example
precious-onyenaucheya-ons Nov 28, 2024
3555877
fix failing test
precious-onyenaucheya-ons Nov 28, 2024
2d3c0d0
Merge branch 'main' into feature/189/add-horizontal-description-list
precious-onyenaucheya-ons Nov 28, 2024
6b953a8
address div issue
precious-onyenaucheya-ons Nov 29, 2024
c62a87d
approve visual tests
precious-onyenaucheya-ons Nov 29, 2024
5dd8f0e
update breakpoints
precious-onyenaucheya-ons Nov 29, 2024
56775f8
update css
precious-onyenaucheya-ons Nov 29, 2024
0470ee4
fix typo
precious-onyenaucheya-ons Dec 2, 2024
f08e1b6
add initial changes
precious-onyenaucheya-ons Nov 27, 2024
6cec1f9
add icon
precious-onyenaucheya-ons Nov 27, 2024
321221d
update example
precious-onyenaucheya-ons Nov 28, 2024
2040158
update variant
precious-onyenaucheya-ons Nov 29, 2024
db6f29d
update
precious-onyenaucheya-ons Nov 29, 2024
224586e
Merge branch 'main' into feature/189/add-horizontal-description-list
precious-onyenaucheya-ons Dec 2, 2024
83e02d7
add test
precious-onyenaucheya-ons Dec 3, 2024
4fbc009
refactor to fit inline variant with figma design
precious-onyenaucheya-ons Dec 4, 2024
2f21710
approve visual test
precious-onyenaucheya-ons Dec 4, 2024
4ce8321
Merge branch 'main' into feature/189/add-horizontal-description-list
precious-onyenaucheya-ons Dec 4, 2024
f6ab261
fix accessibility issues
precious-onyenaucheya-ons Dec 4, 2024
724349b
fix grid issues
precious-onyenaucheya-ons Dec 5, 2024
0680abb
approve visual test
precious-onyenaucheya-ons Dec 5, 2024
7bc83cd
Merge remote-tracking branch 'origin' into feature/165/analysis-hero
precious-onyenaucheya-ons Dec 5, 2024
eca78b6
Merge branch 'feature/189/add-horizontal-description-list' into featu…
precious-onyenaucheya-ons Dec 5, 2024
1140c34
add minor changes and fix failing test
precious-onyenaucheya-ons Dec 5, 2024
11e71bb
Update src/components/description-list/_description-list.scss
precious-onyenaucheya-ons Dec 5, 2024
5938ce0
Update src/components/description-list/_macro.njk
precious-onyenaucheya-ons Dec 5, 2024
a42b1ce
Update src/components/description-list/_description-list.scss
precious-onyenaucheya-ons Dec 5, 2024
27bd708
revert changes
precious-onyenaucheya-ons Dec 5, 2024
b23bbf1
update column width
precious-onyenaucheya-ons Dec 6, 2024
035b326
update styling
precious-onyenaucheya-ons Dec 6, 2024
ff0de57
remove margin from item
precious-onyenaucheya-ons Dec 6, 2024
a5ba67b
Merge branch 'feature/189/add-horizontal-description-list' into featu…
precious-onyenaucheya-ons Dec 6, 2024
4d43469
Merge branch 'main' into feature/165/analysis-hero
precious-onyenaucheya-ons Dec 9, 2024
d9b3d83
update
precious-onyenaucheya-ons Dec 16, 2024
ba37ef9
revert changes
precious-onyenaucheya-ons Dec 16, 2024
65d5a14
update css and test
precious-onyenaucheya-ons Dec 16, 2024
094b8c9
fix failing test
precious-onyenaucheya-ons Dec 16, 2024
8031227
Merge branch 'main' into feature/165/analysis-hero
SriHV Dec 17, 2024
407d259
Merge branch 'main' into feature/165/analysis-hero
precious-onyenaucheya-ons Dec 18, 2024
12506cb
update as per PR comments
precious-onyenaucheya-ons Dec 19, 2024
32b2240
fix failing test
precious-onyenaucheya-ons Dec 19, 2024
eca6592
update reference
precious-onyenaucheya-ons Dec 19, 2024
a782f5c
update docs
precious-onyenaucheya-ons Dec 19, 2024
f174579
update style and approve test
precious-onyenaucheya-ons Dec 19, 2024
fc29acb
remove magin bottom from topic
precious-onyenaucheya-ons Dec 20, 2024
fa3e2b8
changes as per comments
SriHV Jan 6, 2025
4449d1b
changed grey color name
SriHV Jan 6, 2025
ba0682c
changed badge to officialStatisticsBadge in macro file
SriHV Jan 6, 2025
69e3aeb
fixed macro tests
SriHV Jan 6, 2025
d313493
fixed visual tests
SriHV Jan 6, 2025
c134d76
changes as per comments
SriHV Jan 9, 2025
1d2098e
Merge branch 'main' into feature/165/analysis-hero
SriHV Jan 10, 2025
c170cda
changes as per comments
SriHV Jan 13, 2025
ef7d849
Merge branch 'main' into feature/165/analysis-hero
SriHV Jan 13, 2025
ab9ffd8
Update src/components/hero/_macro.njk
SriHV Jan 13, 2025
ac22e21
Update src/components/hero/_macro.njk
SriHV Jan 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update style and approve test
precious-onyenaucheya-ons committed Dec 19, 2024
commit f174579496a6c675e994f0afa0a7fb99938a9933
admilne marked this conversation as resolved.
Show resolved Hide resolved
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/components/hero/_hero.scss
Original file line number Diff line number Diff line change
@@ -46,7 +46,7 @@
}
}
&__badge {
@include mq(xs) {
@include mq(xs, l) {
margin-top: 2.5rem;
margin-bottom: 1rem;
}