This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 60
Resolve Code Review Comments #10
Open
vamagra
wants to merge
1
commit into
vamagra-patch-1
Choose a base branch
from
vamagra-patch-2
base: vamagra-patch-1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,17 +82,17 @@ In addition, every bot must be registered in the Bot Framework, so it is accessi | |
|
||
* You’ll return to the Registration page, with the App ID filled in, that matches the one created above. Check the box at the bottom to agree to the terms of use, and click “Register” to create your new accessible Bot Framework bot. | ||
|
||
* Click on the Microsoft Teams icon under “Add a featured channel.” | ||
* On the new page that opens once your app is done being created, click on the Microsoft Teams icon under "Add a featured channel" in order to allow your bot to use this channel. | ||
|
||
* Check the box to agree to the Terms of Service. | ||
|
||
* Click “Done” on the Configure MS Teams page in the bottom left hand corner. | ||
|
||
* Bots and Microsoft Azure – When you edit the properties of an existing bot in the list of your bots in Bot Framework such as its messaging endpoint, which is common when first developing a bot, especially if you use ngrok, you will see the "Migration status" column and a blue "Migrate" button that will take you into the Microsoft Azure portal. Don't click on the "Migrate" button unless that's what you want to do; instead, click on the name of the bot and you can edit its properties. | ||
|
||
* If you register your bot using Microsoft Azure, it does not need to be hosted on Microsoft Azure. | ||
* If you do register a bot using the Microsoft Azure portal, it does not need to be hosted on Microsoft Azure. | ||
|
||
* If you do register a bot using Microsoft Azure portal, you must have a Microsoft Azure account. You can create one for free. To verify your identity when you create one, you must provide a credit card, but it won't be charged; it's always free to create and use bots with Microsoft Teams. | ||
* If you do register a bot using the Microsoft Azure portal, you must have a Microsoft Azure account. You can create one for free. To verify your identity when you create one, you must provide a credit card, but it won't be charged; it's always free to create and use bots with Microsoft Teams. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change so that the formatting is correct with this when viewed in the actual view. (so that it doesn't show up with the *) |
||
|
||
3. You project needs to run with a configuration that matches your registered bot's configuration. To do this, you will need to update the web.config file: | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you added the "the" and "portal", but change the "do" and "a" back to "your bot" so that this bullet and the next do not start with the exact same phrase.